Skip to content

Fixed typo error#16247

Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
gelanivishal:typo-error-2
Jun 22, 2018
Merged

Fixed typo error#16247
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
gelanivishal:typo-error-2

Conversation

@gelanivishal
Copy link
Copy Markdown
Contributor

@gelanivishal gelanivishal commented Jun 19, 2018

Description

Fixed typo error.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Jun 19, 2018

Hi @vgelani. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@phoenix128 phoenix128 self-assigned this Jun 19, 2018
phoenix128
phoenix128 approved these changes Jun 19, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@phoenix128 phoenix128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vgelani for your contribution.

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.6 milestone Jun 19, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Jun 19, 2018

Hi @phoenix128, thank you for the review.
ENGCOM-2055 has been created to process this Pull Request

@phoenix128
Copy link
Copy Markdown
Contributor

phoenix128 commented Jun 19, 2018

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Jun 19, 2018

Hi @phoenix128. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Jun 19, 2018

Hi @phoenix128, here is your Magento instance.
Admin access: https://pr-16247.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Please make sure you are PR author or assignee to access the instance.

@orlangur orlangur added the typo label Jun 20, 2018
@magento-engcom-team magento-engcom-team merged commit 3ca26eb into magento:2.2-develop Jun 22, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 22, 2018
@VladimirZaets
ENGCOM-2055: Fixed typo error #16247
6752614
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Jun 22, 2018

Hi @vgelani. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

This was referenced Jun 22, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@phoenix128 phoenix128 phoenix128 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@phoenix128 phoenix128

Labels

Area: Frontend Area: Lib/Frontend Cleanup Component: Paypal Progress: accept Release Line: 2.2

Projects

None yet

Milestone

Release: 2.2.6

Development

Successfully merging this pull request may close these issues.

4 participants

@gelanivishal @magento-engcom-team @phoenix128 @orlangur